New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for links of file paths with spaces (#13245) #43733
Added support for links of file paths with spaces (#13245) #43733
Conversation
I see that I have 1 failing:
Is this a know instability or is it using this link pattern matching? PS C:\git\vscode> .\scripts\test.bat --run "C:/git/vscode/extensions/vscode-api-tests/out/singlefolder-tests/workspace.test.js" it hangs and doesn't do anything. Also, I see that 1 of the 3 travis jobs failed after 50 mins for hanging. |
@DominikDitoIvosevic thanks for your PR. Travis failing you can ignore. However unit tests you probably broke since they are passing nicely wihtout your changes. |
…into bugs/13245/doivosev/linkSpaceCaptureFix
@isidorn I was locally having issues with running tests because I was using the default git checkout style using clrf and your tests are hardcoded to work with LF. I see that after remerging with master my tests pass on appveyor but travis still fails. Does this mean the last fail was an instability and my PR is ok? |
I tried allowing spaces in all the file patterns but there seems to be a bigger issue here. You have to choose between more path characters or more variations from which we can extract paths. One problem is that while on Windows While I think it's important to support spaces for all path patterns, allowing spaces for the last of the 3 patterns would require you to enforce specifying some character after the path. For instance some tests have |
@isidorn could you please tell me if there is something else I need to do? Could we get a review started up? |
@DominikDitoIvosevic Hi, this week we are in the endgame week, which means we only take limited code changes we are cruical for the release. |
@isidorn Does this mean this fix is potentially getting into 1.22 or 1.23? |
@DominikDitoIvosevic 1.22 |
@DominikDitoIvosevic I checked out your changes and they make sense to me. I would merge them in so we try them out in insiders and see if something breaks. @DominikDitoIvosevic did you bild vscode with your changes and verify nothing gets badly broken? Like detecting links in various outputs? |
Let's merge this in and see how it behaves in the wild. |
Hi.
This is just a regex improvement to capture links with spaces as well.
The approach is to use an OR non capturing group which does (validChar | space+validChar)* instead of previously using just validChar*
Fixes:
#13245
and
microsoft/AL#167